Skip to content

fix: Set required Java version to 1.8 in flow-maven-plugin#23398

Merged
mcollovati merged 2 commits into2.13from
flow-maven-plugin-java8
Feb 9, 2026
Merged

fix: Set required Java version to 1.8 in flow-maven-plugin#23398
mcollovati merged 2 commits into2.13from
flow-maven-plugin-java8

Conversation

@TatuLund
Copy link
Contributor

@TatuLund TatuLund commented Feb 3, 2026

Adapted from: vaadin/maven-plugin#176

@mcollovati
Copy link
Collaborator

I'm a bit confused: the documentation for maven-plugin-plugin says that requiredJavaVersion is evaluated by Maven 4 and ignored by earlier Maven versions..
Also, the property is marked Since: 3.8.0, but in the Flow 2.x branch the plugin version is 3.5.2

https://maven.apache.org/plugin-tools/maven-plugin-plugin/descriptor-mojo.html

@mcollovati
Copy link
Collaborator

So the check has been introduced also in Maven 3.9.12 (apache/maven#11479).

@TatuLund
Copy link
Contributor Author

TatuLund commented Feb 3, 2026

So the check has been introduced also in Maven 3.9.12 (apache/maven#11479).

Yes, it was just observed in one case with Vaadin 7

https://vaadin.com/forum/t/error-the-plugin-com-vaadin7-7-46-and-java-11-check/179171

Co-authored-by: Marco Collovati <marco@vaadin.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2026

@mcollovati mcollovati merged commit b050d0d into 2.13 Feb 9, 2026
9 checks passed
@mcollovati mcollovati deleted the flow-maven-plugin-java8 branch February 9, 2026 09:11
@mcollovati
Copy link
Collaborator

We need to make similar PRs for all Flow, Hilla and platform maintained branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants